Skip to content

Conversation

Ayushjain2205
Copy link
Contributor

Description

Script added for Password Manager GUI. This lets the user enter and store passwords safely in a local SQL Database

Fixes #694

Have you read the Contributing Guidelines on Pull Requests?

  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions:

  • Create a master password for the database and prompt to authenticate every time user clicks on show-all. You need the SQLCipher module to read that database. The default SQLite3 module has no support for that.
  • The alignment in showing passwords is not so good. Use some layouts to position them correctly.

@kaustubhgupta kaustubhgupta added the enhancement New feature or request label Mar 24, 2021
@Ayushjain2205
Copy link
Contributor Author

@kaustubhgupta Sure will work on these suggestions and get back

@kaustubhgupta
Copy link
Contributor

@Ayushjain2205 updates?

@Ayushjain2205
Copy link
Contributor Author

Ayushjain2205 commented Mar 26, 2021

@kaustubhgupta There is This issue when pysqlcipher is installed with pip. Is it ok or will it cause a problem because I will be specifying it in the requirements file but it wont get installed properly from it

@Ayushjain2205
Copy link
Contributor Author

@kaustubhgupta I am not able to install pysqlcipher from the link given in the above issue. Can you please guide me how I can install it because I am unable to use it even after successful installation of it through pip

@kaustubhgupta
Copy link
Contributor

@kaustubhgupta
Copy link
Contributor

@Ayushjain2205 did you try this?

@kaustubhgupta
Copy link
Contributor

@Ayushjain2205
Copy link
Contributor Author

Try this: https://github.com/Monogi/pysqlcipher3_install_win10

I tried this but I was not able to install it. I will go ahead with the new method you sent

@kaustubhgupta
Copy link
Contributor

@Ayushjain2205 updates?

@Ayushjain2205
Copy link
Contributor Author

Ayushjain2205 commented Mar 31, 2021

Some suggestions:

  • Create a master password for the database and prompt to authenticate every time user clicks on show-all. You need the SQLCipher module to read that database. The default SQLite3 module has no support for that.
  • The alignment in showing passwords is not so good. Use some layouts to position them correctly.

@kaustubhgupta I have created the master password functionality. The user needs to add the master password as a command line argument and whenever the user clicks show all he needs to enter the password.
Only on successful authentication all passwords will be shown.

Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayushjain2205 Good Job 💯 💯

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed enhancement New feature or request labels Mar 31, 2021
Copy link
Contributor

@santushtisharma10 santushtisharma10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @Ayushjain2205 💯💯

@kaustubhgupta
Copy link
Contributor

@Kushal997-das

@kaustubhgupta
Copy link
Contributor

@antrikshmisri

@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants and removed next review needed Approved by some mentors, more approvals needed labels Apr 3, 2021
@kaustubhgupta kaustubhgupta added the level2 Bug fixing, Adding small features label Apr 3, 2021
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@avinashkranjan avinashkranjan merged commit ec7c886 into avinashkranjan:master Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password manager GUI
5 participants